fix(aria-allowed-element): Add fieldset to allowed elements for radiogroup #2326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
straker
approved these changes
Jun 25, 2020
There was a problem hiding this comment.
Thanks for the pr. Confirmed in https://www.w3.org/TR/html-aria/#el-fieldset as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those resources mention that
radiogroupsupports being named based onlegend:https://w3c.github.io/aria/#radiogroup
https://w3c.github.io/aria/#namefromlegend
This mentions what naming by legend is (which is somewhat self-explanatory, but pasting it here for completeness):
https://w3c.github.io/aria/#namecalculation
And we know that
legendmust be a descendant of afieldset.In addition to that MDN mentions explicitly that
radiogroupis allowed for afieldset:https://developer.mozilla.org/en-US/docs/Web/HTML/Element/fieldset#Technical_summary
Reviewer checks
Required fields, to be filled out by PR reviewer(s)