Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aria-allowed-element): Add fieldset to allowed elements for radiogroup #2326

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

Andarist
Copy link
Contributor

@Andarist Andarist commented Jun 25, 2020

Those resources mention that radiogroup supports being named based on legend:
https://w3c.github.io/aria/#radiogroup
https://w3c.github.io/aria/#namefromlegend

This mentions what naming by legend is (which is somewhat self-explanatory, but pasting it here for completeness):
https://w3c.github.io/aria/#namecalculation

And we know that legend must be a descendant of a fieldset.

In addition to that MDN mentions explicitly that radiogroup is allowed for a fieldset:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/fieldset#Technical_summary

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@Andarist Andarist requested a review from a team as a code owner June 25, 2020 11:38
Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr. Confirmed in https://www.w3.org/TR/html-aria/#el-fieldset as well.

@straker straker merged commit a5409d4 into dequelabs:develop Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants